Skip to content

Rename CLUSTER env var to CLUSTER_NAME for consistency#4656

Open
tuxerrante wants to merge 2 commits intomasterfrom
tuxerrante/fix-cluster-env-var-name
Open

Rename CLUSTER env var to CLUSTER_NAME for consistency#4656
tuxerrante wants to merge 2 commits intomasterfrom
tuxerrante/fix-cluster-env-var-name

Conversation

@tuxerrante
Copy link
Collaborator

@tuxerrante tuxerrante commented Mar 5, 2026 •
edited
Loading

Summary

  • Renames CLUSTER to CLUSTER_NAME in env.example, hack/setup_resources.sh, and all references I could find

Test plan

  • go build ./... passes
  • go test ./... passes
  • make lint-go passes

mociarain
mociarain reviewed Mar 5, 2026
View reviewed changes
Copy link
Collaborator

@mociarain mociarain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the risk of a naming spiral:

My preference would be to make everything CLUSTER_NAME rather than CLUSTER. We already have a pattern of CLUSTER_SOMETHING and it's no obvious to me that just CLUSTER would be the name

@tuxerrante
Copy link
Collaborator Author

tuxerrante commented Mar 5, 2026 •
edited
Loading

@mociarain

My preference would be to make everything CLUSTER_NAME rather than CLUSTER. We already have a pattern of CLUSTER_SOMETHING and it's no obvious to me that just CLUSTER would be the name

I actually agree with you,
I have chosen the way of the less impact as per default,
I'm happy to move the change on the other name

@tuxerrante tuxerrante mentioned this pull request Mar 5, 2026
Open
1 task
@mrWinston
Copy link
Collaborator

mrWinston commented Mar 5, 2026

@mociarain

My preference would be to make everything CLUSTER_NAME rather than CLUSTER. We already have a pattern of CLUSTER_SOMETHING and it's no obvious to me that just CLUSTER would be the name

I actually agree with you, I have chosen the way of the less impact as per default, I'm happy to move the change on the other name

Yes, i was just about to suggest the same :) I'd prefer to commit to CLUSTER_NAME as well.

@tuxerrante tuxerrante force-pushed the tuxerrante/fix-cluster-env-var-name branch from 430c035 to 1b978bb Compare March 5, 2026 15:01
@tuxerrante tuxerrante requested a review from mociarain March 5, 2026 15:02
@tuxerrante tuxerrante changed the title Rename CLUSTER_NAME env var to CLUSTER for consistency Rename CLUSTER env var to CLUSTER_NAME for consistency Mar 5, 2026
aasserzo
aasserzo reviewed Mar 10, 2026
View reviewed changes
alcasim
alcasim reviewed Mar 10, 2026
View reviewed changes
alcasim
alcasim reviewed Mar 10, 2026
View reviewed changes
@tuxerrante tuxerrante force-pushed the tuxerrante/fix-cluster-env-var-name branch 2 times, most recently from 1253959 to 656131f Compare March 10, 2026 09:16
@tuxerrante
Rename CLUSTER env var to CLUSTER_NAME for consistency
3da45c3 
CLUSTER_NAME is more descriptive than the bare CLUSTER. This renames
the environment variable everywhere: Go code, Makefile, shell scripts,
CI pipeline, docker-compose, and documentation.
@tuxerrante tuxerrante force-pushed the tuxerrante/fix-cluster-env-var-name branch from 656131f to 3da45c3 Compare March 10, 2026 09:20
alcasim
alcasim reviewed Mar 10, 2026
View reviewed changes
alcasim
alcasim reviewed Mar 10, 2026
View reviewed changes
@tuxerrante @claude
Remove unused CLUSTER_NAME var and stale TODO comment
e7a53ee 
- Remove unnecessary CLUSTER_NAME env var from operator run command
  in guardrails README (cmd/aro operator doesn't read it)
- Remove stale TODO about billing pipelines (no billing pipelines exist)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@tuxerrante tuxerrante requested review from aasserzo and alcasim March 10, 2026 10:04
rh-returners
rh-returners approved these changes Mar 12, 2026
View reviewed changes
Copy link
Collaborator

@rh-returners rh-returners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really makes sense to do , since we need to start working on consistency!

lgtm!

@bizz001
Copy link
Collaborator

bizz001 commented Mar 13, 2026

This change will break E2E in production which sets cluster name to CLUSTER. We first need to merge a PR there to set both variable in order to avoid E2E "downtime".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rh-returners rh-returners rh-returners approved these changes

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@mrWinston mrWinston Awaiting requested review from mrWinston mrWinston is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese is a code owner

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@tiguelu tiguelu Awaiting requested review from tiguelu tiguelu is a code owner

@kimorris27 kimorris27 Awaiting requested review from kimorris27 kimorris27 is a code owner

@tsatam tsatam Awaiting requested review from tsatam tsatam is a code owner

@sankur-codes sankur-codes Awaiting requested review from sankur-codes sankur-codes is a code owner

@wanghaoran1988 wanghaoran1988 Awaiting requested review from wanghaoran1988 wanghaoran1988 is a code owner

@ventifus ventifus Awaiting requested review from ventifus ventifus is a code owner

@mociarain mociarain Awaiting requested review from mociarain mociarain is a code owner

@aasserzo aasserzo Awaiting requested review from aasserzo

@alcasim alcasim Awaiting requested review from alcasim alcasim is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tuxerrante @mrWinston @bizz001 @mociarain @alcasim @aasserzo @rh-returners